-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aerosols #724
Update Aerosols #724
Conversation
Implement aerosol forcing parameters to account for the new analysis by Zelinka et al. (2023)
|
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (aab43a8). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #724 +/- ##
======================================
Coverage ? 80.15%
======================================
Files ? 61
Lines ? 5992
Branches ? 0
======================================
Hits ? 4803
Misses ? 1189
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor commenting issues to consider.
Also, do the SSPs vary in their aerosol emissions? I assume yes, and if so might be useful to document if these changes have a bigger effect in e.g. ssp585.
^ Good point on SSPs, worth testing. I'd say just compare new/old, but if the total forcing is not that much difference could just be a comment in text - to keep the extra work down. (The nature of this change is that there's offsetting positive and negative forcing impacts, so its only going to be a pretty specific circumstance where this makes a large difference.). |
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (aab43a8). |
Across the SPPs the total changes on RF total/temp are really small!
MSE Global Temp
MSE RF BC
|
Is MSE mean square error? If so I'm a little confused by that, but anyway, trust your judgment. Thanks! |
Related to #700, update the aerosol scalers