[FIX] FE로부터 넘어오는 redirect URI 를 검증힙니다. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kssumin
approved these changes
Dec 8, 2024
| @@ -27,4 +29,10 @@ public TokenModel login(String loginId, String password) { | |||
| OAuthMemberEntity entity = authService.authenticate(loginId, password); | |||
| return authenticationTokenGenerator.execute(entity.getMemberId()); | |||
| } | |||
|
|
|||
| private String validate(String uri) { | |||
There was a problem hiding this comment.
return uri.trim()
.replaceAll("[\n\r\t ]", "");trim, 정규표현식을 사용해서 이렇게 표현해도 좋을 것 같아요~
- trim() : 문자열의 앞뒤 공백 제거(우리 지금 문제 원인)
- 정규표현식 : 줄바꿈, 탭, 스페이스 제거
There was a problem hiding this comment.
오 어떻게 쓸지 고민했는데 저렇게 쓰면 되겠네요~ 감사합니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
#180
✒️ 작업 내용
스크린샷 🏞️ (선택)
💬 REVIEWER에게 요구사항 💬