Skip to content

Commit

Permalink
Fix test broken by dependency updates
Browse files Browse the repository at this point in the history
EqualsVerifier did not like having two fields with the same name for an object.

git-svn-id: https://josm.openstreetmap.de/svn/trunk@19294 0c6e7542-c601-0410-84e7-c038aed88b3b
  • Loading branch information
taylor.smock committed Jan 28, 2025
1 parent b4688cb commit 3e43e20
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions src/org/openstreetmap/josm/command/AddPrimitivesCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/
public class AddPrimitivesCommand extends Command {

private List<PrimitiveData> data;
private List<PrimitiveData> primitiveData;
private Collection<PrimitiveData> toSelect;
private List<PrimitiveData> preExistingData;

Expand Down Expand Up @@ -55,9 +55,9 @@ public AddPrimitivesCommand(List<PrimitiveData> data, DataSet ds) {

private void init(List<PrimitiveData> data, List<PrimitiveData> toSelect) {
CheckParameterUtil.ensureParameterNotNull(data, "data");
this.data = new ArrayList<>(data);
this.primitiveData = new ArrayList<>(data);
if (toSelect == data) {
this.toSelect = this.data;
this.toSelect = this.primitiveData;
} else if (toSelect != null) {
this.toSelect = new ArrayList<>(toSelect);
}
Expand All @@ -75,10 +75,10 @@ public boolean executeCommand() {

private void executeRealCommand(DataSet ds) {
if (createdPrimitives == null) { // first time execution
List<OsmPrimitive> newPrimitives = new ArrayList<>(data.size());
List<OsmPrimitive> newPrimitives = new ArrayList<>(primitiveData.size());
preExistingData = new ArrayList<>();

for (PrimitiveData pd : data) {
for (PrimitiveData pd : primitiveData) {
OsmPrimitive primitive = ds.getPrimitiveById(pd);
boolean created = primitive == null;
if (primitive == null) {
Expand All @@ -98,7 +98,7 @@ private void executeRealCommand(DataSet ds) {
// Then load ways and relations
for (int i = 0; i < newPrimitives.size(); i++) {
if (!(newPrimitives.get(i) instanceof Node)) {
newPrimitives.get(i).load(data.get(i));
newPrimitives.get(i).load(primitiveData.get(i));
}
}
newPrimitives.forEach(p -> p.setModified(true));
Expand All @@ -107,7 +107,7 @@ private void executeRealCommand(DataSet ds) {
// a subsequent command (e.g. MoveCommand) cannot be redone.
for (OsmPrimitive osm : createdPrimitives) {
if (preExistingData.stream().anyMatch(pd -> pd.getPrimitiveId().equals(osm.getPrimitiveId()))) {
Optional<PrimitiveData> o = data.stream()
Optional<PrimitiveData> o = primitiveData.stream()
.filter(pd -> pd.getPrimitiveId().equals(osm.getPrimitiveId())).findAny();
o.ifPresent(osm::load);
} else {
Expand All @@ -120,8 +120,8 @@ private void executeRealCommand(DataSet ds) {
@Override public void undoCommand() {
DataSet ds = getAffectedDataSet();
if (createdPrimitives == null) {
createdPrimitives = new ArrayList<>(data.size());
for (PrimitiveData pd : data) {
createdPrimitives = new ArrayList<>(primitiveData.size());
for (PrimitiveData pd : primitiveData) {
OsmPrimitive p = ds.getPrimitiveById(pd);
createdPrimitives.add(p);
}
Expand All @@ -146,7 +146,7 @@ private void executeRealCommand(DataSet ds) {

@Override
public String getDescriptionText() {
int size = data != null ? data.size() : createdPrimitives.size();
int size = primitiveData != null ? primitiveData.size() : createdPrimitives.size();
return trn("Added {0} object", "Added {0} objects", size, size);
}

Expand All @@ -161,14 +161,14 @@ public Collection<? extends OsmPrimitive> getParticipatingPrimitives() {
if (createdPrimitives != null)
return createdPrimitives;

return data.stream()
return primitiveData.stream()
.map(d -> Objects.requireNonNull(getAffectedDataSet().getPrimitiveById(d), () -> "No primitive found for " + d))
.collect(Collectors.toSet());
}

@Override
public int hashCode() {
return Objects.hash(super.hashCode(), data, toSelect, preExistingData, createdPrimitives);
return Objects.hash(super.hashCode(), primitiveData, toSelect, preExistingData, createdPrimitives);
}

@Override
Expand All @@ -177,7 +177,7 @@ public boolean equals(Object obj) {
if (obj == null || getClass() != obj.getClass()) return false;
if (!super.equals(obj)) return false;
AddPrimitivesCommand that = (AddPrimitivesCommand) obj;
return Objects.equals(data, that.data) &&
return Objects.equals(primitiveData, that.primitiveData) &&
Objects.equals(toSelect, that.toSelect) &&
Objects.equals(preExistingData, that.preExistingData) &&
Objects.equals(createdPrimitives, that.createdPrimitives);
Expand Down

0 comments on commit 3e43e20

Please sign in to comment.