-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes in assign_job_queue.R, cleanup.R, lineage.R, msa.R, tree.R #106
Open
SunSummoner
wants to merge
5
commits into
JRaviLab:main
Choose a base branch
from
SunSummoner:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c8633bd
Made changes in assign_job_queue.R, cleanup.R, lineage.R, msa.R, tree.R
SunSummoner a3247de
Merge commit 'b758992729ba7310fb7dc553259ac5c9d5ae6fca'
the-mayer d1bedab
remove .data prefix from param
the-mayer 1a68176
kalign seems to come from an external GitHub repo -- removing from na…
the-mayer 1ba4da6
revert .data additions
the-mayer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# File to put all data.table variables that aren't defined otherwise | ||
|
||
#' @importFrom utils globalVariables | ||
utils::globalVariables(c("Protein")) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,9 +59,6 @@ | |
convertFA2Tree <- function(fa_path = here("data/alns/pspa_snf7.fa"), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If these default/example files don't exist, we could remove them. Otherwise, placeholders that work might be a good idea! |
||
tre_path = here("data/alns/pspa_snf7.tre"), | ||
fasttree_path = here("src/FastTree")) { | ||
# fa_path=here("data/alns/pspa_snf7.fa") | ||
# tre_path=here("data/alns/pspa_snf7.tre") | ||
# fasttree_path=here("src/FastTree") | ||
|
||
# Check if the FASTA file exists | ||
if (!file.exists(fa_path)) { | ||
|
@@ -89,7 +86,7 @@ convertFA2Tree <- function(fa_path = here("data/alns/pspa_snf7.fa"), | |
message(fa_path) | ||
system2( | ||
command = fasttree_path, | ||
args = paste(c(fa_path, ">", tre_path), | ||
args = paste(c(fa_path, ">", .data$tre_path), | ||
sep = "", collapse = " " | ||
) | ||
) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed and makes me think that the
IPG2Lineage()
function defined in acc2lin.R may be more recent/relevant.mergedTax
looks like it may have been pulled from the Global Environment at some point in the past -- it will not work as it exists in this function.Again, this is outside the scope of this issue, but something we will need to disambiguate (acc2lin.R vs lineage.R)/correct moving forward!