Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework 1 : Submission #4

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

otmanesabir
Copy link

No description provided.

@ereator
Copy link
Collaborator

ereator commented Oct 6, 2020

Thank you for the pull request. I accept your submission.
There are some minor issues which should be avoided in the future submissions.
Minor issues:

  • Extra files were committed
  • No rendered images were submitted
  • Changed files that should not have been changed (e.g. CMakeLists.txt, .gitignore, appveyor.yml, etc)

I admit that the proposed structure may be better than the original one, however changes in the project structure makes the grading process much more difficult.

@otmanesabir
Copy link
Author

Thank you for your feedback.

I only realized after reading the new homework details that we were not supposed to edit any other files and were also supposed to add renders to a separate directory - I will make sure the diff view is minimal next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants