Assignment6 #6
Open
Assignment6 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereator
reviewed
Dec 25, 2020
| @@ -2,7 +2,7 @@ | |||
| **Dealine**: 26.11.2020 | |||
|
|
|||
| Please put your name here: | |||
| **Name:** ....... | |||
| **Name:** Katrin von Seggern, Jordan Streete | |||
There was a problem hiding this comment.
Please make separate submissions, otherwise I need an explanation who was doing what.
| */ | ||
| int n = getNumSamples(); | ||
| float m = sqrt(n); | ||
| float i = s % n; |
There was a problem hiding this comment.
Here should be also m instead of n
| */ | ||
| int n = getNumSamples(); | ||
| float m = sqrt(n); | ||
| float i = s % n; |
There was a problem hiding this comment.
Here should be also m instead of n
| return std::nullopt; | ||
| Vec2f samples(0, 0); | ||
| //also taken from OpenRT | ||
| size_t i = 0; |
There was a problem hiding this comment.
This variable must be static or member-variable, otherwise it is zero all the time
| @@ -30,19 +30,51 @@ class CShaderGlossy : public CShaderPhong { | |||
| Vec3f normal = ray.hit->getNormal(ray); // shading normal | |||
There was a problem hiding this comment.
I suspect Plagiarism for this problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.