HW5 Solution #8
HW5 Solution #8
Conversation
| // --- PUT YOUR CODE HERE --- | ||
| return Vec2f::all(0.5f); | ||
| { | ||
| return Vec2f::all(Random::U<float>()); |
There was a problem hiding this comment.
Here both components will be initialized with the same random number. U() method will be called only once.
| { | ||
| size_t n = sqrt(this->getNumSamples()); | ||
| // get i, j from row major format | ||
| float i = (s % getNumSamples()) + 0.5; |
There was a problem hiding this comment.
In such case I will be equal to 0 all the time, you need to use n here
| return Vec2f::all(0.5f); | ||
| auto rd = Random::U<float>(); | ||
| size_t n = sqrt(this->getNumSamples()); | ||
| float i = s % getNumSamples(); |
| size_t n = sqrt(this->getNumSamples()); | ||
| float i = s % getNumSamples(); | ||
| float j = (float)s / n; | ||
| return Vec2f((j + rd) / n, (i + rd) / n); |
| if (res2.has_value()) | ||
| { | ||
| k++; | ||
| agg += res2.value() * m_glossiness; |
There was a problem hiding this comment.
it is a mis-use go the glossiness effect. This implementation just makes glossiness to vanish, but the m_glossiness parameter should modulate how much the normal is deviated - thus, for m_glossiness close to 1, the samples should be concentrated on top of the hemisphere, whereas for small m_glossiness close to 0, the samples should be equally distributed over the hemisphere
| float y = r * sinf(theta); | ||
| s = Vec2f(x, y); | ||
| float z = sqrtf(max(0.0f, 1.0f - s[0] * s[0] - s[1] * s[1])); | ||
| auto nS = Vec3f(s[0], s[1], z); |
There was a problem hiding this comment.
You derive nS, but never use it. It should be used instead of the normal. m_glossiness should also participate in the derivation of the nS. For example, for glossiness close to 1, you can divide x and y parameters by a large number, etc.
There was a problem hiding this comment.
So, the code above is not in use
No description provided.