footer bg changed

[OMIIIEE]

now footer is visible clearly in dark mode . changed background color

[Jenselme]

Thanks for you contribution! I have a few questions/remarks.

For my personal knowledge, how did you find out about the project and why did you want to contribute (I don’t think it very known yet)?

[Jenselme]

Why force this? There is a theme selector in the navbar to choose how to display: automatic theme from system, light or dark. So I don’t think this is necessary.

[Jenselme]

I don’t think we should redefine colors. Removing the bg-* classes on footer and updating the behavior of .content-footer should be enough:

.content-footer {
  height: var(--content-mobile-footer-height);
  background-color: var(--bs-dark);
}

[data-bs-theme="dark"] .content-footer {
  background-color: var(--bs-tertiary-bg);
}

This way, we have the same footer as today on light (which I like) and on dark the footer has the same color than the navbar. What do you think?

Note: with your current modification, footer on light theme is broken.

[Jenselme]

@OMIIIEE any questions on my remarks?

[Jenselme]

@OMIIIEE hello, any opinions on the feedback I provided?

Without answer from you, I’ll take the liberty to take back this issue 😉