Skip to content

Commit

Permalink
Gradle Plugin: Force kotlinx-coroutines version 1.8.0-RC2 for web tar…
Browse files Browse the repository at this point in the history
…gets in user projects (#4278)

Removed such the version substituion from the resources library. The
versions will be subtituted now by gradle plugin.
  • Loading branch information
eymar authored Feb 10, 2024
1 parent e680f9f commit c4bc761
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 13 deletions.
13 changes: 0 additions & 13 deletions components/resources/library/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -204,16 +204,3 @@ afterEvaluate {
if (name == "compileWebMainKotlinMetadata") enabled = false
}
}

// TODO: remove this (https://youtrack.jetbrains.com/issue/COMPOSE-939)
configurations.all {
val isWeb = name.startsWith("wasmJs") || name.startsWith("js")
if (isWeb) {
resolutionStrategy.eachDependency {
if (requested.group.startsWith("org.jetbrains.kotlinx") &&
requested.name.startsWith("kotlinx-coroutines-")) {
useVersion("1.8.0-RC2")
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,23 @@ abstract class ComposePlugin : Plugin<Project> {

disableSignatureClashCheck(project)
}

// TODO: remove this (https://youtrack.jetbrains.com/issue/COMPOSE-939)
// we substitute the coroutines version for web targets in user projects,
// so they don't need to do that manually
project.configurations.all {
val isWeb = it.name.startsWith("wasmJs") || it.name.startsWith("js")
if (isWeb) {
it.resolutionStrategy.eachDependency {
if (it.requested.group.startsWith("org.jetbrains.kotlinx") &&
it.requested.name.startsWith("kotlinx-coroutines-")) {
if (it.requested.version?.startsWith("1.8") != true) {
it.useVersion("1.8.0-RC2")
}
}
}
}
}
}

private fun disableSignatureClashCheck(project: Project) {
Expand Down

0 comments on commit c4bc761

Please sign in to comment.