-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for k/wasm #4009
Merged
Merged
Update for k/wasm #4009
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f9db956
Update gradle plugin: disable decoys for k/js, add k/wasm target to e…
cb204a7
Update compose.html to kotlin 1.9.21
eymar 144e6ff
Add an explicit coroutines dependency to compose.html tests
eymar 66e4491
fix compose.html example compose-bird
eymar 9dc662a
Update gradle plugin tests
eymar 49387a8
Update gradle-plugins/gradle.properties
eymar 91aee00
Update html/gradle.properties
eymar f3c590d
Update kotlin versions in some gradle tests for k/native
eymar 8ff0999
tmp ignore test
eymar 6a8668a
Try with 1.6.0-dev1268
eymar 7ccc50a
Remove ignore
eymar f8eb8e8
Update gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/t…
eymar 8c9776d
Update gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/t…
eymar 1160b28
Update gradle-plugins/gradle.properties
eymar 90167b2
Update
cf0593c
add -Xmx8096M
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,16 +12,16 @@ import org.junit.jupiter.api.Test | |
|
||
class KotlinCompatibilityTest : GradlePluginTestBase() { | ||
@Test | ||
fun testKotlinMpp_1_7_10() = testMpp("1.7.10") | ||
fun testKotlinMpp_1_9_10() = testMpp("1.9.10") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. older kotlin/js versions don't support libs build with 1.9.x, therefore an update here was necessary |
||
|
||
@Test | ||
fun testKotlinJsMpp_1_7_10() = testJsMpp("1.7.10") | ||
fun testKotlinJsMpp_1_9_10() = testJsMpp("1.9.10") | ||
|
||
@Test | ||
fun testKotlinMpp_1_7_20() = testMpp("1.7.20") | ||
fun testKotlinMpp_1_9_20() = testMpp("1.9.20") | ||
|
||
@Test | ||
fun testKotlinJsMpp_1_7_20() = testJsMpp("1.7.20") | ||
fun testKotlinJsMpp_1_9_20() = testJsMpp("1.9.20") | ||
|
||
private fun testMpp(kotlinVersion: String) = with( | ||
testProject( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
kotlin.version=1.8.21 | ||
kotlin.version=1.9.21 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
compose.version=1.5.1 | ||
compose.version=1.6.0-alpha01 | ||
compose.web.buildSamples=false | ||
compose.web.tests.integration.withFirefox | ||
compose.web.tests.skip.benchmarks=false | ||
org.gradle.jvmargs=-Xmx8g | ||
|
||
# TODO: figure out why jvmTest (web driver tests) fail with timeout with kotlin 1.9.0 | ||
integrationTestsEnabled=false | ||
integrationTestsEnabled=false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our compose-core is built using 1.9.21. Its metadata version is 1.9.x
Kotlin 1.7.x used in these tests failed with an error about medata version mismatch.
Therefore, I updated kotlin versions here.