Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle "8.6" and AGP "7.3.1", "8.2.2" to the gradle plugin integration tests #4309

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

terrakok
Copy link
Member

@terrakok terrakok commented Feb 15, 2024

The PR adds two versions of the AGP to run integration tests.

@igordmn igordmn self-requested a review February 16, 2024 11:32
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, except we still need to fix GitHub CI and test it on TeamCity

@@ -30,7 +31,7 @@ jobs:
run: |
cd gradle-plugins
./gradlew assemble
./gradlew --continue :preview-rpc:test :compose:test :compose:testGradle-${{ matrix.gradle }}
./gradlew --continue :preview-rpc:test :compose:test ':compose:test-Gradle(${{ matrix.gradle }})-Agp(${{ matrix.agp }})'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrakok terrakok requested a review from igordmn February 16, 2024 16:07
@terrakok terrakok force-pushed the k.tskh/varios-agp branch 2 times, most recently from 3e33c7b to 0fa0b69 Compare March 1, 2024 16:35
terrakok added 5 commits March 4, 2024 14:44
It fails DesktopApplicationTest.proguard test on Windows:
Execution failed for task ':createReleaseDistributable'.
> java.io.IOException: Unable to delete directory 'C:\Users\runneradmin\AppData\Local\Temp\junit15199828818905379674\build\compose\binaries\main-release\app'
Failed to delete some children. This might happen because a process has files open or has its working directory set in the target directory.
- C:\Users\runneradmin\AppData\Local\Temp\junit15199828818905379674\build\compose\binaries\main-release\app\simple\simple.exe
- C:\Users\runneradmin\AppData\Local\Temp\junit15199828818905379674\build\compose\binaries\main-release\app\simple

More info: gradle/gradle#26912
@terrakok terrakok force-pushed the k.tskh/varios-agp branch from 0fa0b69 to 9bdaa37 Compare March 4, 2024 13:44
@terrakok terrakok merged commit 3348289 into master Mar 4, 2024
12 checks passed
@terrakok terrakok deleted the k.tskh/varios-agp branch March 4, 2024 16:39
igordmn pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants