-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradle "8.6" and AGP "7.3.1", "8.2.2" to the gradle plugin integration tests #4309
Conversation
0ecb5db
to
ecc3600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, except we still need to fix GitHub CI and test it on TeamCity
@@ -30,7 +31,7 @@ jobs: | |||
run: | | |||
cd gradle-plugins | |||
./gradlew assemble | |||
./gradlew --continue :preview-rpc:test :compose:test :compose:testGradle-${{ matrix.gradle }} | |||
./gradlew --continue :preview-rpc:test :compose:test ':compose:test-Gradle(${{ matrix.gradle }})-Agp(${{ matrix.agp }})' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also test this branch on TeamCity: https://teamcity.jetbrains.com/buildConfiguration/JetBrainsPublicProjects_Compose_Publish_2_All_2?mode=builds
a96410a
to
8a5a9db
Compare
3e33c7b
to
0fa0b69
Compare
It fails DesktopApplicationTest.proguard test on Windows: Execution failed for task ':createReleaseDistributable'. > java.io.IOException: Unable to delete directory 'C:\Users\runneradmin\AppData\Local\Temp\junit15199828818905379674\build\compose\binaries\main-release\app' Failed to delete some children. This might happen because a process has files open or has its working directory set in the target directory. - C:\Users\runneradmin\AppData\Local\Temp\junit15199828818905379674\build\compose\binaries\main-release\app\simple\simple.exe - C:\Users\runneradmin\AppData\Local\Temp\junit15199828818905379674\build\compose\binaries\main-release\app\simple More info: gradle/gradle#26912
0fa0b69
to
9bdaa37
Compare
The PR adds two versions of the AGP to run integration tests.