Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix French translation for desiccant #26

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

maxmouchet
Copy link
Contributor

I think "déshydratant" is a better translation :-) This is also what's used on Amazon:

Screenshot 2025-01-27 at 16 54 51

@Jezza34000
Copy link
Owner

Salut Maxime,
Alors effectivement je dois dire que cette traduction m'a posé problème (car oui je dois avouer j'ai fais traduire tout mon fichier FR par une IA alors que je suis bien Francais) mais à mon grand étonnement le terme "dessiccant" est bel est bien Francais. (vs "desiccant" qui lui est en anglais)
Mais je pense que déshydratant parle plus à tout le monde :-)
Je fix la CI et je merge la correction

@maxmouchet
Copy link
Contributor Author

Intéressant, ca sonnait tellement anglais que je n'ai même pas pensé à vérifier, mais effectivement c'est bien Français !

Comme tu préfères, mais effectivement petit préférence personnelle pour "déshydratant" :)

@Jezza34000 Jezza34000 merged commit 5bf7bc1 into Jezza34000:main Jan 28, 2025
4 of 6 checks passed
@Jezza34000
Copy link
Owner

https://github.com/Jezza34000/homeassistant_petkit/releases/tag/1.6.5

@maxmouchet maxmouchet deleted the max/dessicant-translation branch January 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants