Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 🎉 Intra v1.3.9 #499

Merged
merged 1 commit into from
Feb 5, 2024
Merged

release: 🎉 Intra v1.3.9 #499

merged 1 commit into from
Feb 5, 2024

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Feb 1, 2024

No description provided.

@jyyi1 jyyi1 requested a review from fortuna February 1, 2024 22:02
@jyyi1 jyyi1 changed the title release: Intra v1.3.9 release: 🎉 Intra v1.3.9 Feb 1, 2024
@@ -57,8 +57,8 @@ android {
// Firebase Crashlytics requires SDK version 16.
minSdkVersion ANDROID_MIN_SDK_VERSION as int
targetSdkVersion ANDROID_TARGET_SDK_VERSION as int
versionCode 64
versionName "1.3.7"
versionCode 67
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can inject these at build time, so we don't need to change code for releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add any code to the gradle task, for example, download the version from Play Store. But would that be more complicated?

@jyyi1 jyyi1 merged commit b75ed0a into master Feb 5, 2024
4 checks passed
@jyyi1 jyyi1 deleted the release-v1.3.9 branch February 5, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants