Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split: copyOnce may be called more than once #517

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

ignoramous
Copy link
Contributor

@ignoramous ignoramous commented Jun 25, 2024

Called twice when retrier.Write succeeds and returns immediately (L319) without waiting on <-retryCloseFlag (L324).

if attempted {
if err == nil {
return n, nil
}
// A write error occurred on the provisional socket. This should be handled
// by the retry procedure. Block until we have a final socket (which will
// already have replayed b[:n]), and retry.
<-r.retryCompleteFlag

ignoramous referenced this pull request in celzero/firestack Jun 26, 2024
Android/app/src/go/intra/split/retrier.go Outdated Show resolved Hide resolved
@ignoramous ignoramous requested a review from jyyi1 June 29, 2024 08:13
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jyyi1 jyyi1 merged commit c285903 into Jigsaw-Code:master Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants