Fix bug of identity response matrices for PCA background models in Sherpa #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a problem in the identity response matrices created for fitting the PCA background models with Sherpa. While they work fine with the PCA model itself, when applied to a gaussian model they return null values for all channels. This causes that any additional gaussian components included into the baseline PCA model are always rejected.
This PR fixes this issue, by using the create_delta_rmf and create_arf functions included in Sherpa. I have tested the new code with XMM, Chandra, Swift, Suzaku, NuSTAR and eROSITA data, and everything seems to work ok. The new script test_auto_background.py runs a battery of test: first, they check that the PCA model parameters obtained without including additional gaussian lines are the same as in the original code (the original values are stored in json files in the corresponding folders); second, a high count excess is injected into the background spectrum at a given channel and check that the new code is able to model that excess with a gaussian line.