Add the dir HTML attribute

[alobaili]

Since I will be using this package to build my personal website, which will be supporting English and Arabic, I figured the best way to thank you was to add this small contribution.

I added the ability to add the dir attribute in both the Node and Component based APIs.

It is a global attribute that can be added to any HTML elemnt (technically any element including non-HTML, but I didn't focuse on XML in this PR).

I added a new enum called Directionality (the name is inspired from the spec linked above) to hold the three possible values. I made the case names clearer to read and added the actual HTML values as a raw value to each case.

public enum Directionality: String {
    case leftToRight = "ltr"
    case rightToLeft = "rtl"
    case auto = "auto"
}

users can use this like so:

// Support Arabic for the entire document.
let html = HTML(
    .lang(.arabic),
    .dir(.rightToLeft),
    .body(.component(Home())
)

// Or for a specific element.
struct Home: Component {
    var body: Component {
        H1("أهلًا بالعالم!").dir(.auto)
    }
}

I hope I added them to the correct extensions.

Your discussions and comments are always welcome.

[alobaili]

Hello @JohnSundell, could you please review my PR?

Thanks for your time and support.

[alobaili]

Hello @JohnSundell, I'm sorry for any inconvenience. Is there a timeframe we can expect where you usually review PRs for Plot?

Thank you.

[alobaili]

@MrSkwiggs regarding naming the method dir(_:) instead of directionality(_:). This is to match existing names in Plot like H1 and lang. I noticed external names tend to match their HTML counterparts.

What do you think?

[MrSkwiggs]

Makes sense, just got confused initially thinking this was about directories 😆

[majortom64]

@JohnSundell is there a problem with this PR preventing its merge? I have a need for this as well, but do not want to use it if there is an issue.

[majortom64]

@JohnSundell Checking on this again. It has been about 18 months since this was submitted. I really need this, and I am wondering if there is an issue preventing it from being accepted.

[JohnSundell]

A really great addition to Plot, thanks so much @alobaili, and I'm really sorry for taking so ridiculously long to review this!

[JohnSundell]

I accepted @MrSkwiggs suggestion to rename dir to directionality for the Component-based modifier API, since components generally use Swift's default naming conventions, while nodes match their underlying HTML names. Seems like the tests are failing, I'll look into that this evening and will get this PR merged. Again, my sincere apologies for taking so long to review this!

[JohnSundell]

@alobaili Alright, I just needed to update the unit tests for the new directionality API naming as suggested by @MrSkwiggs. I also pushed your fork's master branch to the lastest master of this repo, I hope that's OK. Let me know otherwise and I'll revert back to the commit it was on before. But with that in place this is now ready to be merged in 😀

[alobaili]

@JohnSundell Amazing! I'm glad everything worked out, and thank for accepting my PR. This is one of the very first contributions I made to open source projects that contained actual code 😄.

Thank you for updating my fork as well 🙏.

[JohnSundell]

@alobaili Glad to hear it 😀 Really appreciate your pertinence in waiting for me to FINALLY have some time to go through these Plot PRs and review them. Thanks again for implementing this feature, I'll include it in a new release shortly 👍