Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io

into institutional-access-insti-admin-validation * 'develop' of https://github.com/CenterForOpenScience/osf.io: Avoid superfluous PrivateLink query
Johnetordoff · Jan 3, 2025 · 344f966 · 344f966
2 parents 695ed7b + 10e001b
commit 344f966
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/api_tests/nodes/views/test_node_contributor_insti_admin.py b/api_tests/nodes/views/test_node_contributor_insti_admin.py
@@ -1,13 +1,12 @@
 import pytest
-from osf.models import Contributor, NodeLog
+from osf.models import Contributor
 from osf_tests.factories import (
     AuthUserFactory,
     ProjectFactory,
     InstitutionFactory,
 )
 from api.base.settings.defaults import API_BASE
-from rest_framework import status
-from tests.utils import assert_latest_log
+
 
 
 @pytest.mark.django_db

diff --git a/website/routes.py b/website/routes.py
@@ -176,8 +176,11 @@ def get_globals():
 def is_private_link_anonymous_view():
     # Avoid circular import
     from osf.models import PrivateLink
+    view_only = request.args.get('view_only')
+    if not view_only:
+        return False
     try:
-        return PrivateLink.objects.filter(key=request.args.get('view_only')).values_list('anonymous', flat=True).get()
+        return PrivateLink.objects.filter(key=view_only).values_list('anonymous', flat=True).get()
     except PrivateLink.DoesNotExist:
         return False