forked from CenterForOpenScience/osf.io
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Institutional Access UserMessage features #238
Draft
Johnetordoff
wants to merge
10
commits into
develop
Choose a base branch
from
institutional-access-user-message
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
changed the title
initial commit for UserMessage
[POC] Institutional Access UserMessage features
Dec 2, 2024
Johnetordoff
force-pushed
the
institutional-access-user-message
branch
3 times, most recently
from
December 2, 2024 20:44
d266630
to
e15020d
Compare
Johnetordoff
force-pushed
the
institutional-access-user-message
branch
3 times, most recently
from
December 2, 2024 21:39
c8029fc
to
bf3d324
Compare
Johnetordoff
force-pushed
the
institutional-access-user-message
branch
8 times, most recently
from
December 3, 2024 16:55
cafbd63
to
469e941
Compare
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
|
||
class UserMessageList(JSONAPIBaseView, generics.CreateAPIView): | ||
""" | ||
List and create UserMessages for a user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix this docs
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
commented
Dec 3, 2024
website/mails/mails.py
Outdated
|
||
USER_MESSAGE_INSTITUTIONAL_ACCESS_REQUEST = Mail( | ||
'user_message_institutional_access_request', | ||
subject='Institutional Access Request' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check subject line with Product
Johnetordoff
commented
Dec 3, 2024
Johnetordoff
force-pushed
the
institutional-access-user-message
branch
8 times, most recently
from
December 5, 2024 19:40
ce125ed
to
f7a73c2
Compare
Johnetordoff
force-pushed
the
institutional-access-user-message
branch
from
December 5, 2024 19:41
f7a73c2
to
edb3118
Compare
Johnetordoff
force-pushed
the
institutional-access-user-message
branch
5 times, most recently
from
December 10, 2024 14:05
b97e597
to
cd45df2
Compare
Johnetordoff
force-pushed
the
institutional-access-user-message
branch
from
December 10, 2024 15:25
c91534e
to
f3ab16b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is to allow institutional admins limited messaging capabilities for users within their institution. This PR should allow an email message be sent to an institution member by an admin, using the UserMessage system.
Changes
is_institutional_admin
method to user modelUserMessageFactory
USER_MESSAGE_INSTITUTIONAL_ACCESS_REQUEST
email templateQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket