Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Institutional Access UserMessage features #238

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Johnetordoff
Copy link
Owner

@Johnetordoff Johnetordoff commented Dec 2, 2024

Purpose

This is to allow institutional admins limited messaging capabilities for users within their institution. This PR should allow an email message be sent to an institution member by an admin, using the UserMessage system.

Changes

  • adds UserMessagePermissions
  • adds UserMessage model with MessageType choices
  • adds unit tests
  • adds UserMessageView
  • adds UserMessageSerializer
  • adds is_institutional_admin method to user model
  • adds UserMessageFactory
  • adds USER_MESSAGE_INSTITUTIONAL_ACCESS_REQUEST email template

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

@Johnetordoff Johnetordoff changed the title initial commit for UserMessage [POC] Institutional Access UserMessage features Dec 2, 2024
@Johnetordoff Johnetordoff force-pushed the institutional-access-user-message branch 3 times, most recently from d266630 to e15020d Compare December 2, 2024 20:44
@Johnetordoff Johnetordoff force-pushed the institutional-access-user-message branch 3 times, most recently from c8029fc to bf3d324 Compare December 2, 2024 21:39
@Johnetordoff Johnetordoff force-pushed the institutional-access-user-message branch 8 times, most recently from cafbd63 to 469e941 Compare December 3, 2024 16:55
api/base/parsers.py Outdated Show resolved Hide resolved
api/users/permissions.py Outdated Show resolved Hide resolved
api/users/serializers.py Outdated Show resolved Hide resolved
api/users/serializers.py Outdated Show resolved Hide resolved

class UserMessageList(JSONAPIBaseView, generics.CreateAPIView):
"""
List and create UserMessages for a user.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this docs

osf/models/user.py Outdated Show resolved Hide resolved

USER_MESSAGE_INSTITUTIONAL_ACCESS_REQUEST = Mail(
'user_message_institutional_access_request',
subject='Institutional Access Request'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check subject line with Product

@Johnetordoff Johnetordoff force-pushed the institutional-access-user-message branch 8 times, most recently from ce125ed to f7a73c2 Compare December 5, 2024 19:40
@Johnetordoff Johnetordoff force-pushed the institutional-access-user-message branch from f7a73c2 to edb3118 Compare December 5, 2024 19:41
@Johnetordoff Johnetordoff force-pushed the institutional-access-user-message branch 5 times, most recently from b97e597 to cd45df2 Compare December 10, 2024 14:05
@Johnetordoff Johnetordoff force-pushed the institutional-access-user-message branch from c91534e to f3ab16b Compare December 10, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants