[WIP] NodeRequest improvements for Institutional Access Project #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add management command to migrate preprint affiliations * make sure migrations uses primary instead of replica, improve tests * remove redundant permission --------- Co-authored-by: John Tordoff <>
…penScience#10783) * Add OOPSpam and Akismet metrics to spam report * Add spam/ham metrics for OOPSpam and Akismet with FK join fix, test cleanup * Add private spam metrics report with preprint inclusion * Validate category; add PrivateSpamMetricsReporter to monthly reports --------- Co-authored-by: Uditi Mehta <[email protected]>
prevent counted-usages with different `action_labels` from overwriting each other -- deduplicate only when `action_labels` match exactly
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
3d4de6c to
52aac9f
Compare
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
52aac9f to
92b1da4
Compare
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
2 times, most recently
from
d77d7c4 to
f170de4
Compare
Johnetordoff
changed the title
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
6 times, most recently
from
e3ce081 to
7f351f3
Compare
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
7f351f3 to
c8c6264
Compare
Johnetordoff
commented
Dec 4, 2024
| required=False, | ||
| ) | ||
|
|
||
| def to_internal_value(self, data): |
There was a problem hiding this comment.
Figure out the mystery
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
4 times, most recently
from
ee0d82d to
52dae76
Compare
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
52dae76 to
b0ba9d4
Compare
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
af18d95 to
011b708
Compare
…wn address as a reply_to
…tutional-access-user-message [ENG-6682] Add UserMessage feature for Institutional Access
…terForOpenScience/osf.io into institutional-access-user-message-arb * 'feature/institutional_access' of https://github.com/CenterForOpenScience/osf.io: add user message read/write permissions to full add new user message oauth scope and throttling classes Fix backfill, report Update changelog and bump versions Follow-up fix for target/next (start/end) month Fix failures caused by base class MonthlyReporter update [ENG-6506] Fix: counted-usage clobbers (CenterForOpenScience#10799) [ENG-6435] Fix: duplicate reports when run for past years (CenterForOpenScience#10800) Add PrivateSpamMetricsReport (CenterForOpenScience#10791) [ENG-4438] Add OOPSpam and Akismet metrics to spam report (CenterForOpenScience#10783) [ENG-6364] Migrate Preprint Affilations (CenterForOpenScience#10787)
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
011b708 to
30f4336
Compare
…tutional-access-user-message-arb [ENG-6682] Add reply-to and cc-ing features to Institutional Access
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
5 times, most recently
from
bc9e548 to
d32cc2d
Compare
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
d32cc2d to
b7405af
Compare
added 2 commits
December 12, 2024 14:47
…terForOpenScience/osf.io into institutional-access-node-request-improvements * 'feature/institutional_access' of https://github.com/CenterForOpenScience/osf.io: change to bcc the sender instead of CC-ing them revert typo add code to allow cc-ing fellow institutional admins and put their own address as a reply_to # Conflicts: # osf/migrations/0025_noderequest_requested_permissions_and_more.py
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
a209a8c to
7359973
Compare
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
5cc90b9 to
d8abf97
Compare
Johnetordoff
force-pushed
the
institutional-access-node-request-improvements
branch
from
d8abf97 to
e34b928
Compare
added 2 commits
December 16, 2024 11:30
…e request access is turned off and added test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This feature should allow institutional admins to request a specific project and message a specific user via email with a custom message, the permission should appear as the default selected on the contributor page. This is to be done by expanding the capabilities of the NodeRequest object to allow for this behavior via the current project "Request Access" system
Changes
INSTITUTIONAL_REQUESTSto_internal_valueto serializer to fix relationshipFieldsInstitutionalAdminRequestTypePermissionto handle new request_type.requested_permissionsto NodeRequestSerializerQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
No docs for NodeRequest features.
Side Effects
Ticket