Fix formatter version #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 96.12% 96.12%
=======================================
Files 17 17
Lines 1111 1111
=======================================
Hits 1068 1068
Misses 43 43 ☔ View full report in Codecov by Sentry. |
|
Let's wait for domluna/JuliaFormatter.jl#807. |
I agree. Alternatively, we could also fix the version of JuliaFormatter to an older one without the change of the formatting behavior. |
|
I fixed the version of the JuliaFormatter like we do in Trixi.jl, see trixi-framework/Trixi.jl#1843. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See trixi-framework/Trixi.jl#1842.