add pmmp#5800

README.md

@@ -47,6 +47,7 @@ Additions
 > https://github.com/pmmp/PocketMine-MP/pull/5502
 > https://github.com/pmmp/PocketMine-MP/pull/5581
 > https://github.com/pmmp/PocketMine-MP/pull/5583
+> https://github.com/pmmp/PocketMine-MP/pull/5800
 
 
 ## What is this?

src/block/Block.php

@@ -476,14 +476,19 @@ public function getEnchantmentTags() : array{
 	 * @param Item[] &$returnedItems Items to be added to the target's inventory (or dropped, if full)
 	 */
 	public function onBreak(Item $item, ?Player $player = null, array &$returnedItems = []) : bool{
-		$world = $this->position->getWorld();
-		if(($t = $world->getTile($this->position)) !== null){
-			$t->onBlockDestroyed();
-		}
-		$world->setBlock($this->position, VanillaBlocks::AIR());
+		$this->position->getWorld()->setBlock($this->position, VanillaBlocks::AIR());
 		return true;
 	}
 
+	/**
+	 * Called when this block is destroyed either when a player breaks it or is hit by an explosion.
+	 */
+	public function onDestroy() : void{
+		if(($t = $this->position->getWorld()->getTile($this->position)) !== null){
+			$t->onBlockDestroyed(); //needed to create drops for inventories
+		}
+	}
+
 	/**
 	 * Called when this block or a block immediately adjacent to it changes state.
 	 */

src/block/Jukebox.php

@@ -84,9 +84,9 @@ public function stopSound() : void{
 		$this->position->getWorld()->addSound($this->position, new RecordStopSound());
 	}
 
-	public function onBreak(Item $item, ?Player $player = null, array &$returnedItems = []) : bool{
-		$this->stopSound();
-		return parent::onBreak($item, $player, $returnedItems);
+	public function onDestroy() : void{
+		$this->ejectRecord();
+		parent::onDestroy();
 	}
 
 	public function getDropsForCompatibleTool(Item $item) : array{

src/block/tile/Jukebox.php

@@ -27,7 +27,6 @@
 use pocketmine\item\Record;
 use pocketmine\nbt\tag\CompoundTag;
 use pocketmine\network\mcpe\convert\TypeConverter;
-use pocketmine\world\sound\RecordStopSound;
 
 class Jukebox extends Spawnable{
 	private const TAG_RECORD = "RecordItem"; //Item CompoundTag
@@ -63,8 +62,4 @@ protected function addAdditionalSpawnData(CompoundTag $nbt) : void{
 			$nbt->setTag(self::TAG_RECORD, TypeConverter::getInstance()->getItemTranslator()->toNetworkNbt($this->record));
 		}
 	}
-
-	protected function onBlockDestroyedHook() : void{
-		$this->position->getWorld()->addSound($this->position, new RecordStopSound());
-	}
 }

src/world/Explosion.php

@@ -209,9 +209,7 @@ public function explodeB() : bool{
 						$this->world->dropItem($pos->add(0.5, 0.5, 0.5), $drop);
 					}
 				}
-				if(($t = $this->world->getTileAt($pos->x, $pos->y, $pos->z)) !== null){
-					$t->onBlockDestroyed(); //needed to create drops for inventories
-				}
+				$block->onDestroy();
 				$this->world->setBlockAt($pos->x, $pos->y, $pos->z, $airBlock);
 			}
 		}

src/world/World.php

@@ -2132,10 +2132,7 @@ private function destroyBlockInternal(Block $target, Item $item, ?Player $player
 
 		$target->onBreak($item, $player, $returnedItems);
 
-		$tile = $this->getTile($target->getPosition());
-		if($tile !== null){
-			$tile->onBlockDestroyed();
-		}
+		$target->onDestroy();
 	}
 
 	/**