Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #513 #514

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Fix Issue #513 #514

merged 3 commits into from
Nov 1, 2024

Conversation

hz-xiaxz
Copy link
Contributor

@hz-xiaxz hz-xiaxz commented Oct 30, 2024

Related issues

fix #513

Closes #

Checklist

Copy link
Collaborator

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the bug fix!
I've made a suggestion to avoid deleting the second dbg_generate.
For the CHANGELOG can you write an entry for the header "### Fixed"?

src/debug/helper.jl Show resolved Hide resolved
src/debug/helper.jl Show resolved Hide resolved
@hz-xiaxz
Copy link
Contributor Author

I'm not quite sure how to add tests for this fix. Maybe we shall just test all the function calling methods documented works, or just leave them, since it is really simple.

@hz-xiaxz hz-xiaxz requested a review from abelsiqueira October 31, 2024 21:58
Copy link
Collaborator

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version looks great thanks a lot.
No need to add tests to these functions, as they are just convenience functions used internally for debugging and might change at any time.
This kind of error could have been caught in a different way, though, with something like SnoopCompile, JET, or Aqua (#216, #64) used as linters, but I haven't looked into that yet.
The CHANGELOG entry is also great, thanks

@abelsiqueira abelsiqueira merged commit 7716574 into JuliaBesties:main Nov 1, 2024
6 checks passed
@abelsiqueira
Copy link
Collaborator

@all-contributors please add @hz-xiaxz for code

Copy link
Contributor

@abelsiqueira

I've put up a pull request to add @hz-xiaxz! 🎉

@visr
Copy link

visr commented Nov 12, 2024

Might be good to tag a release with this PR, because precompilation of the package is broken on the current release:

(@v1.11) pkg> precompile
Precompiling project...
  ? BestieTemplate

julia> using BestieTemplate
Precompiling BestieTemplate...
Info Given BestieTemplate was explicitly requested, output will be shown live
WARNING: Method definition dbg_generate() in module Debug at C:\Users\visser_mn\.julia\packages\BestieTemplate\MI8lx\src\debug\helper.jl:68 overwritten at C:\Users\visser_mn\.julia\packages\BestieTemplate\MI8lx\src\debug\helper.jl:86.
ERROR: Method overwriting is not permitted during Module precompilation. Use `__precompile__(false)` to opt-out of precompilation.
  ? BestieTemplate
[ Info: Precompiling BestieTemplate [e5d671a7-4186-4f1a-bf88-c19b630da94f]
WARNING: Method definition dbg_generate() in module Debug at C:\Users\visser_mn\.julia\packages\BestieTemplate\MI8lx\src\debug\helper.jl:68 overwritten at C:\Users\visser_mn\.julia\packages\BestieTemplate\MI8lx\src\debug\helper.jl:86.
ERROR: Method overwriting is not permitted during Module precompilation. Use `__precompile__(false)` to opt-out of precompilation.
┌ Info: Skipping precompilation due to precompilable error. Importing BestieTemplate [e5d671a7-4186-4f1a-bf88-c19b630da94f].
└   exception = Error when precompiling module, potentially caused by a __precompile__(false) declaration in the module.

@abelsiqueira
Copy link
Collaborator

Will do one now

@abelsiqueira
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Precompilation Error In Julia 1.11
3 participants