add logo + credits + small text changes #9
Conversation
|
Hi @Balinus Do this have your approval to merge? Happy to make small changes if needed -- just let me know when you get a chance. |
README.md
Outdated
|
|
||
| <img src="https://github.com/gaelforget/meta/raw/gfdev01/docs/juliaclimatelogo.png" width="50%"> | ||
|
|
||
| _**Organization logo design:** @cormullion & the @JuliaClimate community [code is here](https://bit.ly/3anhdMp)_ |
There was a problem hiding this comment.
Since it is already a hyperlink, why not just use the actual URL?
https://gist.github.com/gaelforget/4744a63b86f74362a71a89d27de44c90
Also, to make sure the logo is reproducible, perhaps it would be good to add a Manifest.toml, or simply write the Luxor and Colors versions as a comment?
There was a problem hiding this comment.
"Interestingly", gist links are blocked at my office :/
There was a problem hiding this comment.
Since it is already a hyperlink, why not just use the actual URL?
Done
Also, to make sure the logo is reproducible, perhaps it would be good to add a Manifest.toml, or simply write the Luxor and Colors versions as a comment?
Thanks for suggesting this -- doing it here for now. Just reran the gist code with:
[5ae59095] Colors v0.11.2
[ae8d54c2] Luxor v1.7.0
Sorry, I thought I had already approved! :/ |
No worries. Thanks |
Following up on #3 (comment)