Delete unnecessary methods to fix invalidations #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Base.keys() already works on AbstractDict's so we don't need one for Accumulator. - Base.eltype() is already defined for AbstractArray's and CircularBuffer is an AbstractVector so it doesn't need to define it again. - A Base.convert() from AbstractArray to Array is already defined: https://github.com/JuliaLang/julia/blob/1ae41a2c0a3ba49d4b39dc4933dddf952b5f7f3c/base/array.jl#L612
|
Also, damn, nice work on the 97% coverage 👏 |
oxinabox
reviewed
Apr 12, 2024
| @@ -61,8 +61,6 @@ Base.setindex!(ct::Accumulator, x, v) = setindex!(ct.map, x, v) | |||
|
|
|||
| Base.haskey(ct::Accumulator, x) = haskey(ct.map, x) | |||
|
|
|||
| Base.keys(ct::Accumulator) = keys(ct.map) | |||
There was a problem hiding this comment.
technically this adds a level of indirection but it should optimize out with SROA.
|
This is good. thank you. Code that doesn't exist is a lower maintainance burdan. Do you need this backported to 0.18? (we are not likely to be cutting a new release from current #master branch any time soon) |
|
Thanks ❤️ Yeah it would be nice if it was backported, I'll make a PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.keys()already works onAbstractDict's so we don't need one forAccumulator.Base.eltype()is already defined forAbstractArray's andCircularBufferis anAbstractVectorso it doesn't need to define it again.Base.convert()method fromAbstractArraytoArrayis already defined: https://github.com/JuliaLang/julia/blob/1ae41a2c0a3ba49d4b39dc4933dddf952b5f7f3c/base/array.jl#L612I found these through looking at invalidations from Dagger.jl (CC @jpsamaroo). Before:
After:
There are still some invalidations left, but AFAICT they're necessary and/or would require changes to Base to fix.