Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a dot literal:
Currently this will give an assertion exception when layout discovers the graph.handle is C_NULL. Actually Graphviz is confused that there is a -> and it's not a digraph.
This PR handles null return values from the cgraph functions immediately and converts them into Julia exceptions. Unfortunately this does not give very good error messages (the actual error message is still just printed to stderr), however it's a bit better than the current situation, which is even less since nice in Pluto.jl since stderr is currently not routed to the Notebook by default.
I made an attempt to try and capture the error message in
jl_putstr
andjlio_write
so that it could be put onto the exception, but this did not work out. For some reason Graphviz is not routing the error messages through these callbacks.