Canvas creation #32
Canvas creation #32
Conversation
…errors when shapes which are partially in the images are attempted to be drawn.
…g paths that went 'off image'
…d background with a given number and colors
| Creates an image of with the given colortype and size. | ||
| Defaults to a black solid image | ||
| """ | ||
| generatecanvas(colortype::Type, x::Int, y::Int) = zeros(colortype, (x,y)) |
There was a problem hiding this comment.
Since the work is being done by zeros, why do we effectively have to create an alias to it?
There was a problem hiding this comment.
You're right. I have done this a different way. We can scrap this merge request. We can stick a stripped function in when needed.
|
|
||
| Paints the entire given image a solid color | ||
| """ | ||
| function draw!(img::AbstractArray{T,2}, b::SolidBackground) where {T<:Colorant} |
There was a problem hiding this comment.
Again seems redundant with standard names:
julia> A = fill(colorant"red", 2, 2)
2×2 Array{RGB{N0f8},2} with eltype RGB{Normed{UInt8,8}}:
RGB{N0f8}(1.0,0.0,0.0) RGB{N0f8}(1.0,0.0,0.0)
RGB{N0f8}(1.0,0.0,0.0) RGB{N0f8}(1.0,0.0,0.0)
julia> fill!(A, colorant"blue")
2×2 Array{RGB{N0f8},2} with eltype RGB{Normed{UInt8,8}}:
RGB{N0f8}(0.0,0.0,1.0) RGB{N0f8}(0.0,0.0,1.0)
RGB{N0f8}(0.0,0.0,1.0) RGB{N0f8}(0.0,0.0,1.0)|
|
||
| Layers colors onto a given image to set a "background" | ||
| """ | ||
| function draw!(img::AbstractArray{T,2}, b::StripedBackground) where {T<:Colorant} |
There was a problem hiding this comment.
This one is interesting and adds novel functionality. However, you seem to implicitly assume that img is an all-zeros array, in which case maybe this shouldn't take img as an argument? Should we have a function called stripes?
There was a problem hiding this comment.
Also worth asking: how often do you use angles different from 0 and π/2? If your stripes are all rectilinear then there are easier implementations.
There was a problem hiding this comment.
I was more trying to make it completely general. A stripes function might be preferable and not dealing with backgrounds. Its just fit better into the flow of the module I am making.
| cnt += 1 | ||
| elseif img[i,j] == c | ||
| break | ||
| elseif img[i,j] in b.colors[1:e-1] |
There was a problem hiding this comment.
Slow. How about an auxiliary array that indicates whether a given pixel has already been handled?
Added a canvas creation function. Allows for creating images with a specified background. Currently Solid and a striped background