Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rref from RowEchelon.jl #39386

Closed
wants to merge 2 commits into from
Closed

add rref from RowEchelon.jl #39386

wants to merge 2 commits into from

Conversation

pranshumalik14
Copy link

Adding rref into LinearAlgebra. Currently under draft to get build and coverage updates.

@DilumAluthge
Copy link
Member

Out of curiosity, why does this need to go into the LinearAlgebra stdlib? If it is currently working fine in a package, wouldn't it be better to just keep it in a package?

@pranshumalik14
Copy link
Author

The package RowEchelon.jl is waiting to be integrated into the family of standard linalg operations. It is a handy function, often used to check hand calculations. Issue #9804 has a long discussion about it. There is also an option to put this into GenericLinearAlgebra.jl (#17). I am open to receive any feedback on where this would fit better because I also see that rank is being deprecated and to be moved somewhere else. If a plan for this is finalized somewhere, I would be happy to go over it and work on this accordingly.

@DilumAluthge
Copy link
Member

I would rather add this to GenericLinearAlgebra.jl than to a stdlib. It's much easier to develop, improve, and release code in packages than stdlibs, because stdlibs are constrained by the development and release cycle of the Julia language.

@pranshumalik14
Copy link
Author

Mhmm, that makes sense! My only fear at the moment is that GenericLinearAlgebra.jl has type piracy breaking things in many packages; my understanding of this topic is limited, but yeah I agree with you. It is more practical to have it there. Hopefully, this piracy issue gets resolved soon so that GLA is more amenable to be used in packages in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants