Disable response buffering for /admin/logs #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch disables buffering for the streaming endpoint /admin/logs by setting the special nginx proxy response header X-Accel-Buffering to "no". Even though the default buffering settings seems to work fairly well without too many buffer hiccups it is recommended to disable buffering for this type of streaming endpoints. As an alternative, buffering can be disabled in the nginx config by introducing a new /admin/logs location block, but since the scope here is very narrow it seems much simpler to just set the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disables buffering for the streaming endpoint /admin/logs by setting the special nginx proxy response header X-Accel-Buffering to "no". Even though the default buffering settings seems to work fairly well without too many buffer hiccups it is recommended to disable buffering for this type of streaming endpoints.
As an alternative, buffering can be disabled in the nginx config by introducing a new /admin/logs location block, but since the scope here is very narrow it seems much simpler to just set the header.