Add recipe for CLFFT #5613
Add recipe for CLFFT #5613
Conversation
|
It seems some OpenCL environment variables are not found. What is a good method to define these variables and try to expand the list of supported platforms? |
There was a problem hiding this comment.
This package seems to have a pretty rubbish build system (forcing -m64 for all targets.....) and it's failing to compile for macOS with what look like genuine error in the source code. I wouldn't even know where to start from.
It seems some OpenCL environment variables are not found. What is a good method to define these variables and try to expand the list of supported platforms?
What are you referring to in particular?
Co-authored-by: Mosè Giordano <[email protected]>
I will try to contact the clFFT maintainers to see if they can help with this. I am impressed how these CL libraries have super rough build systems. I thought more people used them.
I remember seeing some warnings in the build saying that some OPENCL_VERSION variables were not set, but I will investigate it more carefully. |
Perhaps not many do cross-compilation. |
|
@giordano another one ready for review. I hope the number of issues is reduced compared to previous contributions. |
|
Another issue with this particular recipe that I would like to ask here is that I am seeing some warnings from the Auditor: ┌ Warning: Minimum instruction set detected for lib64/libclFFT.so.2.12.2 is avx2, not x86_64 as desired.
└ @ BinaryBuilder.Auditor ~/.julia/packages/BinaryBuilder/wohhx/src/Auditor.jl:311
┌ Warning: Minimum instruction set detected for lib64/libclFFT.so.2.12.2 is avx2, not x86_64 as desired.
└ @ BinaryBuilder.Auditor ~/.julia/packages/BinaryBuilder/wohhx/src/Auditor.jl:311
┌ Warning: Minimum instruction set detected for lib64/libclFFT.so.2.12.2 is avx2, not x86_64 as desired.
└ @ BinaryBuilder.Auditor ~/.julia/packages/BinaryBuilder/wohhx/src/Auditor.jl:311
┌ Warning: Minimum instruction set detected for lib64/libclFFT.so.2.12.2 is avx2, not x86_64 as desired.
└ @ BinaryBuilder.Auditor ~/.julia/packages/BinaryBuilder/wohhx/src/Auditor.jl:311Do you think that this super problematic? Also, it would be great if BinaryBuilder.jl could print the current platform being built so that we know where these warnings are coming from. A message like "Info: Building for x86_64-linux-gnu..." |
|
@giordano what about the warnings above? Do you have any advise? |
|
That's ok(-ish) |
This is the last PR in a series of PRs to revive OpenCL + CLFFT binaries for OpenCL.jl and CLFFT.jl respectively.
Appreciate if you can review @giordano. In particular, could you please double check which dependency is a BuildDependency and which is an actual Dependency? That is not 100% clear for me.