Trilinos: Build Kokkos and Teko packages #7384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are dependencies of charon, which I'd like to build (#7383).
|
Alright, so we don't have Kokkos on 32bit, which we can probably make conditional. The build error in atomics is in a file that was removed in kokkos/kokkos@52953c8, so can probably be addressed by a version bump. |
|
Actually, I just realized, we already have a standalone kokkos build in https://github.com/JuliaPackaging/Yggdrasil/blob/master/K/Kokkos/build_tarballs.jl. I don't think it makes sense to duplicate that here, so I probably need to figure out how to depend on that so that I can build Teko against it. |
Keno
added a commit
that referenced
this pull request
Sep 20, 2023
This is the latest version. Before I try to mess with the Kokkos build (#7384), better update, since the Kokkos integration has changed a fair bit on Trilinos master.
Merged
Keno
added a commit
that referenced
this pull request
Sep 20, 2023
|
Superseded by #7386. |
Keno
added a commit
that referenced
this pull request
Sep 21, 2023
* Trilinos: Update to 14.4.0 This is the latest version. Before I try to mess with the Kokkos build (#7384), better update, since the Kokkos integration has changed a fair bit on Trilinos master. * Drop patches These got merged in trilinos/Trilinos#9641. * Use newer cmake * Factor options more nicely * Drop libgfortran3 * Correct version spelling * Add Kokkos dependency * Add patch to use external Kokkos instead * Fix Teko build * Add missing patch file * Build Kokkos-dependent libraries only if available * Forbid libgfortran4 also * Fix missing export on windows * Why do I keep forgetting the patch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are dependencies of charon, which I'd like to build (#7383).