Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alsa_plugins] Bump to v1.2.7, build for experimental platforms #8486

Closed
wants to merge 14 commits into from
Closed

[alsa_plugins] Bump to v1.2.7, build for experimental platforms #8486

wants to merge 14 commits into from

Conversation

gnadt
Copy link

@gnadt gnadt commented Apr 16, 2024

Uses the plugin directory option here

@gnadt
Copy link
Author

gnadt commented Apr 16, 2024

Can't seem to get gnueabihf and musleabihf to find all libraries, not sure why or what to try next

./configure --prefix=${prefix} --build=${MACHTYPE} --host=${target}
make
make install
"""

# These are the platforms we will build for by default, unless further
# platforms are passed in on the command line
platforms = filter!(Sys.islinux, supported_platforms())

platforms = filter(Sys.islinux, supported_platforms(;experimental=true))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

experimental is empty right now, so this doesn't actually change anything.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, I had a suspicion. I just changed it to match up with what [alsa] does.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why libraries for gnueabihf and musleabihf seem to be built into multiple locations?

@gnadt
Copy link
Author

gnadt commented Apr 16, 2024

Removed armv6l from the platform list, but note that it wasn't included in the builds before either: https://github.com/JuliaBinaryWrappers/alsa_plugins_jll.jl/tree/main/src/wrappers

@giordano
Copy link
Member

This PR is mixing changes from #8485?

@gnadt
Copy link
Author

gnadt commented Apr 16, 2024

Yeah let's close this one, I'll open a new PR that keeps the changes of alsa vs alsa_plugins separate

@gnadt gnadt closed this Apr 16, 2024
@gnadt gnadt deleted the alsa_plugins branch April 16, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants