-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build scripts for XRT #9290
Conversation
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
The Windows version of this library is only compatible with MSVC, so I had to do several patches to make it work with MinGW. |
That's awesome, thanks! Would you also be able to submit PRs upstream with those patches? As a downstream project, keeping around multiple patches is cumbersome and hard to maintain (and hard to evaluate for us, as people not familiar with the upstream codebase), upstreaming the patches instead benefits other users as well |
Sure, I will try this. However, it won't change anything for this specific release version. |
I opened a PR with the in my eyes relevant changes to XRT. How do we proceed with this PR? Should we wait until the changes are merged to XRT? But as already mentioned, that will not affect the current release. |
Adds build scripts for XRT, a runtime for AI Engines and FPGA platforms.
WIP because it depends on #9270