Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build scripts for XRT #9290

Merged
merged 28 commits into from
Sep 2, 2024
Merged

Add build scripts for XRT #9290

merged 28 commits into from
Sep 2, 2024

Conversation

Mellich
Copy link
Contributor

@Mellich Mellich commented Aug 21, 2024

Adds build scripts for XRT, a runtime for AI Engines and FPGA platforms.
WIP because it depends on #9270

X/xrt/build_tarballs.jl Outdated Show resolved Hide resolved
X/xrt/build_tarballs.jl Outdated Show resolved Hide resolved
X/xrt/build_tarballs.jl Outdated Show resolved Hide resolved
X/xrt/build_tarballs.jl Outdated Show resolved Hide resolved
X/xrt/build_tarballs.jl Outdated Show resolved Hide resolved
@Mellich Mellich marked this pull request as ready for review August 30, 2024 22:16
@Mellich
Copy link
Contributor Author

Mellich commented Aug 30, 2024

The Windows version of this library is only compatible with MSVC, so I had to do several patches to make it work with MinGW.

@giordano
Copy link
Member

That's awesome, thanks! Would you also be able to submit PRs upstream with those patches? As a downstream project, keeping around multiple patches is cumbersome and hard to maintain (and hard to evaluate for us, as people not familiar with the upstream codebase), upstreaming the patches instead benefits other users as well

@Mellich
Copy link
Contributor Author

Mellich commented Aug 31, 2024

Sure, I will try this. However, it won't change anything for this specific release version.
Unfortunately, I also had to disable some tracing functionality for the Windows build because it depends on TraceLoggingProvider.h.

@Mellich
Copy link
Contributor Author

Mellich commented Sep 2, 2024

I opened a PR with the in my eyes relevant changes to XRT. How do we proceed with this PR? Should we wait until the changes are merged to XRT? But as already mentioned, that will not affect the current release.

@giordano giordano merged commit 08c88f1 into JuliaPackaging:master Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants