[SIRIUS] New package SIRIUS v7.6.0 #9315
Conversation
Sounds like you should pass to CMake the result of the test instead of calling CMake twice. I'm even surprised the second time it ignores the configuration error. |
|
Hello, this is a gentle ping to consider my PR. Thanks! |
|
Can somebody have a look, please? I need this to go through to progress in my work. Thanks! |
|
|
||
| cmake .. ${CMAKE_ARGS} | ||
|
|
||
| #On MacOS, need to explicitly remove the -fallow-argument-mismatch flag, because not recognized by Clang |
There was a problem hiding this comment.
I should say I'm a bit confused by this comment: -fallow-argument-mismatch is a gfortran option and we use gfortran as fortran compiler on all platforms. If this flag is being passed to a C/C++ compiler that looks like a bug of the build system.
There was a problem hiding this comment.
It is indeed clang++ that complains with this flag. I had a quick look on the SIRIUS side, and I could not find any explicit mention of the flag. The source of this issue is somewhat hidden
|
Thank you for the review. I revised the recipe and included most suggested changes. |
|
Gentle ping to review this PR, I'd like to go forward with my work, and I need this JLL package. Thanks! |
* [SIRIUS] New package SIRIUS v7.6.0 * Fix double cmake call * revision * Constrain HDF5 version * Bump to version 7.6.1
New build recipe for the SIRIUS library, a C/C++ library for electronic structure calculations (density functional theory).
Note that the
cmakecommand is run twice in a row. If not, a cryptic error message appears:I am happy to hear suggestions on how to tackle this.
The jll package is only built for linux-x86_64, linux-aarch64 and macos-aarch64. This is a conscious decision.