don't write nans into zlims (#4643)

* don't write nans into zlims * fix test
JuliaPlots · Jan 27, 2023 · 2142220 · 2142220
1 parent ae88be7
commit 2142220
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/backends/plotly.jl b/src/backends/plotly.jl
@@ -557,7 +557,7 @@ function plotly_series(plt::Plot, series::Series)
 
     plotattributes_out[:colorbar] = plotly_colorbar(sp)
 
-    if is_2tuple(clims)
+    if is_2tuple(clims) && all(!isnan, clims)
         plotattributes_out[:zmin], plotattributes_out[:zmax] = clims
     end
 

diff --git a/test/test_plotly.jl b/test/test_plotly.jl
@@ -1,10 +1,12 @@
+using Plots, Test
 with(:plotly) do
     @testset "Basic" begin
         @test backend() == Plots.PlotlyBackend()
 
         pl = plot(rand(10))
-        @test pl isa Plot
+        @test pl isa Plots.Plot
         @test_nowarn Plots.plotly_series(plot())
+        @test !haskey(Plots.plotly_series(pl)[1], :zmax)
     end
 
     @testset "Contours" begin