Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docstring in semcor #34

Merged

Conversation

tejasvaidhyadev
Copy link
Member

As per issue #31. I am adding offline Docstring for SemCor and willing to do the same in others as well. Do you have any suggestions?

@oxinabox
Copy link
Member

commits from #33 seem to be in here as well

@tejasvaidhyadev
Copy link
Member Author

yeah
Should there be any changes?

@oxinabox
Copy link
Member

for now just rebase off master and it should be sorted

@Ayushk4
Copy link
Member

Ayushk4 commented Dec 30, 2019

Something still seems to be wrong with git history. Can you look into it @tejasvaidhyadev ?

@tejasvaidhyadev tejasvaidhyadev force-pushed the Adding-Docstring-in-Semcor branch from 1d50a80 to bc30de5 Compare December 30, 2019 06:34
src/SemCor.jl Outdated Show resolved Hide resolved
@tejasvaidhyadev
Copy link
Member Author

Can you review my PR and should i add doc string for others @oxinabox and @Ayushk4

src/SemCor.jl Outdated Show resolved Hide resolved
Co-Authored-By: Lyndon White <[email protected]>
@oxinabox oxinabox merged commit b5f8037 into JuliaText:master Jan 2, 2020
@oxinabox
Copy link
Member

oxinabox commented Jan 2, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants