-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docstring in semcor #34
Merged
oxinabox
merged 4 commits into
JuliaText:master
from
tejasvaidhyadev:Adding-Docstring-in-Semcor
Jan 2, 2020
Merged
Adding docstring in semcor #34
oxinabox
merged 4 commits into
JuliaText:master
from
tejasvaidhyadev:Adding-Docstring-in-Semcor
Jan 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Dec 28, 2019
commits from #33 seem to be in here as well |
yeah |
for now just rebase off |
Co-Authored-By: Lyndon White <[email protected]>
Something still seems to be wrong with git history. Can you look into it @tejasvaidhyadev ? |
tejasvaidhyadev
force-pushed
the
Adding-Docstring-in-Semcor
branch
from
December 30, 2019 06:34
1d50a80
to
bc30de5
Compare
Ayushk4
reviewed
Dec 30, 2019
oxinabox
reviewed
Jan 2, 2020
Co-Authored-By: Lyndon White <[email protected]>
oxinabox
approved these changes
Jan 2, 2020
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #31. I am adding offline Docstring for SemCor and willing to do the same in others as well. Do you have any suggestions?