Avoid calling PyEval_RestoreThread when python is finalizing #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did this?
sonic_swss_common provides a way to allow multi-threading while python is calling c++ code:
This code calls PyEval_RestoreThread in a destructor which would potentially cause unexpected thread termination:
This issue is found on python3 and there is a statement in python3 official doc about PyEval_RestoreThread https://docs.python.org/3/c-api/init.html:
According to the official doc, _Py_IsFinalizing() should be checked before calling PyEval_RestoreThread. The PR is to fix this issue.