Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German Translation #655

Merged

Conversation

ZuruZockt010
Copy link
Contributor

When merged this pull request will:

  • Describe what this pull request will do
  • Each change in a separate line

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Copy link
Contributor

@OverlordZorn OverlordZorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most stuff is okey, some sentences are a bit clunky, but they are difficult. A few things are completely off.

@ZuruZockt010
Copy link
Contributor Author

Yea your Right , some bit Clumpy :D your secondary "Rewrite" looks better

@MiszczuZPolski
Copy link
Collaborator

Any update on this?

@OverlordZorn
Copy link
Contributor

OverlordZorn commented Dec 20, 2024

Looks like Zuru doesnt know its his turn to act.
my suggested changes were left in pending realm

addons/chemical/stringtable.xml Outdated Show resolved Hide resolved
addons/chemical/stringtable.xml Outdated Show resolved Hide resolved
addons/chemical/stringtable.xml Outdated Show resolved Hide resolved
addons/chemical/stringtable.xml Outdated Show resolved Hide resolved
addons/circulation/stringtable.xml Outdated Show resolved Hide resolved
addons/watch/stringtable.xml Outdated Show resolved Hide resolved
addons/watch/stringtable.xml Outdated Show resolved Hide resolved
addons/watch/stringtable.xml Outdated Show resolved Hide resolved
addons/watch/stringtable.xml Outdated Show resolved Hide resolved
addons/watch/stringtable.xml Outdated Show resolved Hide resolved
@@ -806,6 +824,7 @@
<Portuguese>Colocando</Portuguese>
<Dutch>Wordt geplaatst</Dutch>
<Italian>Posizionamento in corso</Italian>
<German>wird Platziert</German>
Copy link
Contributor

@ItsGiantCookie ItsGiantCookie Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower case p

Suggested change
<German>wird Platziert</German>
<German>Wird platziert</German>

@@ -816,6 +835,7 @@
<Portuguese>Avançar Unidade REBOA</Portuguese>
<Dutch>Voer REBOA eenheid op</Dutch>
<Italian>Avanza l'unità REBOA</Italian>
<German>Vorgezogene REBOA-Einheit</German>
Copy link
Contributor

@ItsGiantCookie ItsGiantCookie Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for pushing the REBOA up, so it should be "REBOA-Einheit vorschieben"

Suggested change
<German>Vorgezogene REBOA-Einheit</German>
<German>REBOA-Einheit vorschieben</German>

@@ -826,6 +846,7 @@
<Portuguese>Avançando</Portuguese>
<Dutch>Wordt opgevoerd</Dutch>
<Italian>Avanzamento in corso</Italian>
<German>Vorwärts</German>
Copy link
Contributor

@ItsGiantCookie ItsGiantCookie Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the last one "Vorschieben" would be better

Suggested change
<German>Vorwärts</German>
<German>Vorschieben</German>

@@ -836,6 +857,7 @@
<Portuguese>Remover Unidade REBOA</Portuguese>
<Dutch>Verwijder REBOA eenheid</Dutch>
<Italian>Rimuovi l'unità REBOA</Italian>
<German>Entfernen Sie die REBOA-Einheit</German>
Copy link
Contributor

@ItsGiantCookie ItsGiantCookie Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"REBOA-Einheit entfernen" would be better

Suggested change
<German>Entfernen Sie die REBOA-Einheit</German>
<German>REBOA-Einheit entfernen</German>

@@ -95,6 +106,7 @@
<Spanish>Pies</Spanish>
<Japanese>フィート</Japanese>
<Italian>Piedi</Italian>
<German>Feet</German>
Copy link
Contributor

@ItsGiantCookie ItsGiantCookie Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feet is not entirely wrong but in german the measurement is usually translated and given in "Fuß"

Suggested change
<German>Feet</German>
<German>Fuß</German>

@ItsGiantCookie
Copy link
Contributor

@ZuruZockt010 Yo, any update on my proposed changes?

@OverlordZorn
Copy link
Contributor

OverlordZorn commented Jan 3, 2025

@ZuruZockt010 Yo, any update on my proposed changes?

@ItsGiantCookie

If you make your proposals as suggestions, they can be directly committed by ether zuru or an kat contributor

https://egghead.io/lessons/github-add-suggestions-in-a-github-pr-review

@ItsGiantCookie
Copy link
Contributor

If you make your proposals as suggestions, they can be directly committed by ether zuru or an kat contributor

https://egghead.io/lessons/github-add-suggestions-in-a-github-pr-review

I always forget that feature, I'll get to it in a bit once I'm home

<French>Appliquer des calculs vitaux simplifiés à l'unité AI. Ce qui peut être utile pour économiser des FPS.</French>
</Key>
<Key ID="STR_KAT_Vitals_FLUID_SHIFT">
<English>Enable Patient Fluid Shift</English>
<Japanese>患者の体液移動を有効化</Japanese>
<Italian>Abilita lo spostamento del fluido del paziente</Italian>
<German>Aktivieren Sie die Patientenflüssigkeitsverschiebung</German>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<German>Aktivieren Sie die Patientenflüssigkeitsverschiebung</German>
<German>Aktiviert Flüssigkeitsverschiebung im Patienten</German>

@MiszczuZPolski MiszczuZPolski merged commit 306bce4 into KAT-Advanced-Medical:dev-Tomcat Jan 5, 2025
3 checks passed
@MiszczuZPolski MiszczuZPolski added this to the 3.0.5 milestone Jan 5, 2025
@MiszczuZPolski MiszczuZPolski added the area/translations Release Notes: **TRANSLATIONS:** label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/translations Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants