flutter: Rewrite flutter frontend to use only the KDDW layouting #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsergio
force-pushed
the
wip/flutter
branch
4 times, most recently
from
7304d84 to
77fcdcb
Compare
This greatly simplifies the flutter port. KDDW now only drives the layouting and doesn't abstract tabs, windows and DnD anymore, which will now be done in Dart. The amount of over-engineered abstractions in C++ was causing it to be a pain to even do simple bug fixes. The code is now very clean in dart, without needing to go back and forth to C++ land for every mouse click. Allows to get rid of dartagnan which broke whenever shiboken or LLVM was updated. Allows to get rid of qcoro co-routines as tests are no longer driven by C++, no need to mix 2 event loops. The state of the port is still dependent on flutter supporting multi-window, but we're now in a position to move faster, as tons of tech debt have been removed.
iamsergio
force-pushed
the
wip/flutter
branch
2 times, most recently
from
593fee8 to
b7df963
Compare
iamsergio
force-pushed
the
wip/flutter
branch
from
b7df963 to
999b07d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the flutter port. KDDW now only drives the layouting and doesn't abstract tabs, windows and DnD anymore, which will now be done in Dart.
The amount of over-engineered abstractions in C++ was causing it to be a pain to even do simple bug fixes. The code is now very clean in dart, without needing to go back and forth to C++ land for every mouse click.
Allows to get rid of dartagnan which broke whenever shiboken or LLVM was updated.
Allows to get rid of qcoro co-routines as tests are no longer driven by C++, no need to mix 2 event loops.
The state of the port is still dependent on flutter supporting multi-window, but we're now in a position to move faster, as tons of tech debt have been removed.