Fix restoring maximized window corner case #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference images commit created. Review carefully, merge or discard it: KDAB/kddockwidgets-reference-test-screenshots@main...update/554 |
For issue #553 On Windows it's possible to have normal geometry in a different screen than the maximized window if you drag a window across monitors and touch an aerosnap edge. While restoring, we need a fake setGeometry() call to set the normal geometry, since Qt doesn't provide QWindow::setNormalGeometry(), that resulted in the window being maximized on the wrong window. The solution is to patch the normal geometry to be in the first screen.
|
Reference images commit created. Review carefully, merge or discard it: KDAB/kddockwidgets-reference-test-screenshots@main...update/554 |
iamsergio
pushed a commit
to KDAB/kddockwidgets-reference-test-screenshots
that referenced
this pull request
Dec 14, 2024
iamsergio
added a commit
to KDAB/kddockwidgets-reference-test-screenshots
that referenced
this pull request
Dec 14, 2024
Reference images from KDAB/KDDockWidgets#554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #553
On Windows it's possible to have normal geometry
in a different screen than the maximized window if you drag a window across monitors and touch an
aerosnap edge.
While restoring, we need a fake setGeometry()
call to set the normal geometry, since Qt doesn't
provide QWindow::setNormalGeometry(), that resulted in the window being maximized on the wrong window.
The solution is to patch the normal geometry to be in the first screen.