Qtquick module #579
Open
Qtquick module #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by using kddw as module. There was a DockWidget.qml file but also a C++ type
Since the check passes, enable it, so CI catches the next unused imports.
It's not used. We can now make qmllint's UnresolvedType fatal in CI
We are clean of these, so make them fatal in CI
By using the actual type instead of just QtObject
iamsergio
force-pushed
the
qtquick_module
branch
2 times, most recently
from
c22dc8a to
338f83b
Compare
These are difficult to fix unless we break api, which would annoy our users.
We have a workaround for QTBUG-101146, but it only works with Qt >= 6.8 (and maybe 6.7, untested). The generated type registrations with newer Qt are guarded with _has_include, so it's fine if we have C++ elements in subfolders not in include path
iamsergio
force-pushed
the
qtquick_module
branch
from
338f83b to
f629131
Compare
This will make QML tooling happier.
iamsergio
force-pushed
the
qtquick_module
branch
from
6291deb to
119f64c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.