Implement auto invocation of deferred slots #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanharmer
reviewed
Jul 10, 2024
MiKom
force-pushed
the
auto-deferred-connections
branch
3 times, most recently
from
1616140 to
875cb63
Compare
Connection invocations are now evaluated automatically in the event loop. Any time an invocation is enqueued using the event loop's connection evaluator, the event loop is woken up. This required a KDUtils-specific ConnectionEvaluator. When given event loop is destroyed, it sets a reference in the evaluator to null. It's a defensive measure for the future to prevent misuse of lingering evaluators in case the user deletes the event loop first. AbstractEventLoop::waitForEvents is not pure abstract anymore as it ensures evaluation of slot invocations. Removed one copypasted comment in android event loop impl.
MiKom
force-pushed
the
auto-deferred-connections
branch
from
875cb63 to
2bec342
Compare
seanharmer
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection invocations are now evaluated automatically in the event loop. Any time an invocation is enqueued using the event loop's connection evaluator, the event loop is woken up.
This required a KDUtils-specific ConnectionEvaluator.
When given event loop is destroyed, it sets a reference in the evaluator to null. It's a defensive measure for the future to prevent misuse of lingering evaluators in case the user deletes the event loop first.
AbstractEventLoop::waitForEvents is not pure abstract anymore as it ensures evaluation of slot invocations.
Removed one copypasted comment in android event loop impl.