Fix clang tidy warnings #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiKom
force-pushed
the
fix-clang-tidy-warnings
branch
4 times, most recently
from
7ea61e0 to
aec72eb
Compare
So it shows up in VSCode.
It warned about unused variable as the SPDLOG_LOGGER_DEBUG is compiled out in release builds.
std::ignore used in cases where we don't need to store the connection. I think it's more descriptive than (void). Technically, using std::ignore is UB until Peppe's P2968 is ratified in C++26 but every implementation we target does the right thing so I don't care. Sue me.
LinuxWaylandPlatformWindow::scaleByFactor converted to template so it can work both for signed and unsigned types without warning.
Setting SYSTEM on FetchContent_Declare for fmt is not good as it requires CMake 3.25 (we want to support older ones) and doesn't work as clang-tidy is still invoked.
For better readability, in xcb-facing code I retained C arrays. While we're at it, replaced one KD_UNUSED with std::ignore.
Some got NOLINT treatment because they are used as wayland callbacks and it's easier to have them this way.
This fixes some issues with exceptions in constructors.
MiKom
force-pushed
the
fix-clang-tidy-warnings
branch
from
aec72eb to
7bacedc
Compare
mkrus
reviewed
Jul 23, 2024
This way we have less NOLINT exceptions.
MiKom
force-pushed
the
fix-clang-tidy-warnings
branch
from
1e0c1c8 to
cd9cdbb
Compare
We throw exceptions in multiple places, particularly in initializing Wayland and XCB. Plus, KDBindings may throw as well and doesn't have any support for turning exceptions on and off. I suggest we create an issue for it and start working on it once the concrete need arises. What do you think @mkrus ? |
mkrus
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a giant PR but it's comprised of (mostly) small atomic commits. So best reviewed commit by commit.
Not everything is fixed yet. Few more complicated ones are left out. Also, fixing warnings in tests will be done separately.