Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openssl to 1.1.1w and 3.1.6. #62

Closed
wants to merge 1 commit into from

Conversation

carlonluca
Copy link

No description provided.

Copy link
Collaborator

@Issam-b Issam-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the versions in the build script https://github.com/KDAB/android_openssl/blob/master/build_ssl.sh#L20C12-L20C28?

Is this build using the script from #61?

@carlonluca
Copy link
Author

Updated the script.
Yes, this is built using the updated script.

@omergoktas
Copy link

@Issam-b @bog-dan-ro, are you seriously going to accept pull requests containing binary blobs? Boss move if so, just sayin'. I hope these kind of moves don't not create another Jia Tan incident. I trust @KDAB because I know the people who work there; but I don't know these people (people in pull requests). Why would I integrate binary blobs produced by strangers?

@Issam-b
Copy link
Collaborator

Issam-b commented Aug 11, 2024

@omergoktas you bring a valid point indeed! Instead, @bog-dan-ro or I would do the update separately and this can be closed.

@Issam-b Issam-b closed this Aug 11, 2024
@omergoktas
Copy link

Thank you, @Issam-b. And I didn't mean to be rude to @carlonluca or anyone trying to contribute to the project, either. You know, that's just how you ensure the security of your repo. Code contributions are ok, but binary is somewhat problematic. Again, thanks to all sides who have been trying to be helpful. 🙏

@carlonluca
Copy link
Author

It seems more than reasonable to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants