QImage: Add conversion from image::RgbaImage #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
qimage-constructors
branch
from
4f238f2 to
955d8c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12426 12426
=========================================
Hits 12426 12426 ☔ View full report in Codecov by Sentry. |
LeonMatthesKDAB
force-pushed
the
qimage-constructors
branch
4 times, most recently
from
3bc2f5e to
15c2008
Compare
LeonMatthesKDAB
added
the
⏮️ backport-candidate
LeonMatthesKDAB
force-pushed
the
qimage-constructors
branch
from
15c2008 to
47f440f
Compare
|
Looks good, small questions and conflicts |
LeonMatthesKDAB
force-pushed
the
qimage-constructors
branch
from
47f440f to
cced1e5
Compare
|
Needs some conflicts resolving otherwise looks good i think. |
milianw
reviewed
Jan 29, 2025
LeonMatthesKDAB
force-pushed
the
qimage-constructors
branch
from
cced1e5 to
d72f971
Compare
LeonMatthesKDAB
force-pushed
the
qimage-constructors
branch
from
d72f971 to
7daa086
Compare
ahayzen-kdab
previously approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Looks good, @LeonMatthesKDAB would still be good to raise an issue around using sanitizers or valgrind of some kind on the cxx-qt-lib tests.
auto-merge was automatically disabled
February 5, 2025 10:20
Rebase failed
Because the image crate changes versions somewhat frequently, the features in CXX-Qt are added with explicit image crate versions.
LeonMatthesKDAB
force-pushed
the
qimage-constructors
branch
from
69dbbe6 to
79905fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the image crate changes versions somewhat frequently, the
features in CXX-Qt are added with explicit image crate versions.