fix: don't create new file from palette #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montel
force-pushed
the
dont_generate_new_file
branch
2 times, most recently
from
018558f to
51523a8
Compare
narnaud
reviewed
Oct 30, 2024
src/core/project.h
Outdated
| @@ -58,7 +58,7 @@ class Project : public QObject | |||
|
|
|||
| public slots: | |||
| Core::Document *get(const QString &fileName); | |||
| Core::Document *open(const QString &fileName); | |||
| Core::Document *open(const QString &fileName, bool onlyExistingFile = false); | |||
There was a problem hiding this comment.
I would prefer to not change this method, as it's an API.
Montel
force-pushed
the
dont_generate_new_file
branch
from
51523a8 to
6f12fbe
Compare
|
Close, please have a look at #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.