Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop overhaul - Attester section #285

Merged
merged 27 commits into from
Dec 2, 2023
Merged

Conversation

ChrisChinchilla
Copy link
Contributor

fixes KILTProtocol/ticket#2956

Overhaul to attester section of workshop content included external contributions.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-285.d3oeht7cvddn19.amplifyapp.com

Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
docs/develop/03_workshop/04_attester/01_account.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/01_account.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/01_account.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/01_account.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/01_account.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/03_ctype.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/03_ctype.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/03_ctype.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/index.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/index.md Outdated Show resolved Hide resolved
@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review November 15, 2023 11:06
Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. It is more cohesive. Reads better. Thanks Chris!

docs/develop/03_workshop/04_attester/01_account.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/02_did.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/02_did.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/03_ctype.md Outdated Show resolved Hide resolved
Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisChinchilla ChrisChinchilla merged commit da7d489 into master Dec 2, 2023
5 of 6 checks passed
@ChrisChinchilla ChrisChinchilla deleted the chrisward/workshop-2 branch December 2, 2023 08:01
ChrisChinchilla added a commit that referenced this pull request Dec 19, 2023
* Draft

Signed-off-by: Chris Chinchilla <[email protected]>

* Reset

Signed-off-by: Chris Chinchilla <[email protected]>

* Draft

Signed-off-by: Chris Chinchilla <[email protected]>

* Attester section

Signed-off-by: Chris Chinchilla <[email protected]>

* Update docs/develop/03_workshop/04_attester/01_account.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/01_account.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/index.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/index.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/01_account.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/03_ctype.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/03_ctype.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/01_account.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/01_account.md

* Add warning

Signed-off-by: Chris Chinchilla <[email protected]>

* Update docs/develop/03_workshop/04_attester/02_did.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/02_did.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/02_did.md

* Update docs/develop/03_workshop/04_attester/02_did.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/03_ctype.md

Co-authored-by: Antonio <[email protected]>

* Update docs/develop/03_workshop/04_attester/03_ctype.md

Co-authored-by: Antonio <[email protected]>

* Changes

Signed-off-by: Chris Chinchilla <[email protected]>

* Changes from feedback

Signed-off-by: Chris Chinchilla <[email protected]>

* Update docs/develop/03_workshop/04_attester/01_account.md

Co-authored-by: Skedley <[email protected]>

* Update docs/develop/03_workshop/04_attester/02_did.md

* Changes from review

Signed-off-by: Chris Chinchilla <[email protected]>

---------

Signed-off-by: Chris Chinchilla <[email protected]>
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Skedley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants