➕ [WV-16] feat : 콘텐츠 영역 레이아웃 컴포넌트 구현 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayoung78
approved these changes
Dec 13, 2024
app/test/page.tsx
Outdated
Comment on lines
97
to
100
|
|
||
| <ContentsArea> | ||
| <div className="h-[1000px]">asdas</div> | ||
| </ContentsArea> |
There was a problem hiding this comment.
이거는 모든 페이지에서 다 해당하는 내용이므로 굳이 component로 뺄필요 없이 layout에 children 묶고있는 div에 넣으면 좋을것 같습니다
components/layout/contents-area.tsx
Outdated
Comment on lines
3
to
11
| const ContentsArea = ({ children }: { children: ReactNode }) => { | ||
| return ( | ||
| <div className="w-full flex justify-center"> | ||
| <div className="w-[1100px] h-auto pt-10 pb-[100px]"> | ||
| {children} | ||
| </div> | ||
| </div> | ||
| ) | ||
| } |
There was a problem hiding this comment.
그렇게 한다면 이 컴포넌트는 필요가 없어지겠죠?
There was a problem hiding this comment.
컴포넌트 삭제 후 layout.tsx에 코드 구현했습니다.
game 주소로 들어가 배너와 콘텐츠 레이아웃 영역 테스트 완료했습니다.
Jinviz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
페이지 콘텐츠 영역 레이아웃 컨포넌트 구현
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
PR details
contents-area.tsx 컴포넌트 (경로: "components/layout/contents-area.tsx")
width 1100px로 공식 홈페이지와 동일하게 스타일링되었습니다.
예시 (사용법)
아래와 같이 레이아웃 컴포넌트 안에 요소를 넣으면 영역 안에 배치됩니다.
When modifying code...