Attempt to resolve peimanja#139

KacperPerschke · Apr 20, 2024 · 7c7e384 · 7c7e384
1 parent b9c0dbb
commit 7c7e384
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/collector/converter_internals.go b/collector/converter_internals.go
@@ -8,6 +8,7 @@ import (
 )
 
 var mulConvDriver = map[string]float64{
+	``:      1,
 	`%`:     0.01,
 	`bytes`: 1,
 	`KB`:    math.Exp2(10),

diff --git a/collector/converter_test.go b/collector/converter_test.go
@@ -49,6 +49,21 @@ func TestConvNum(t *testing.T) {
 			input: `888.88 GB`,
 			want:  954427632517.119995,
 		},
+		{
+			// Covers https://github.com/peimanja/artifactory_exporter/issues/139
+			input: `1`,
+			want:  1.0,
+		},
+		{
+			// Covers https://github.com/peimanja/artifactory_exporter/issues/139
+			input: `44`,
+			want:  44.0,
+		},
+		{
+			// Covers https://github.com/peimanja/artifactory_exporter/issues/139
+			input: `100 %`,
+			want:  1.0,
+		},
 	}
 	for _, tc := range tests {
 		got, err := fakeExporter.convArtiToPromNumber(tc.input)
@@ -94,6 +109,11 @@ func TestConvFileStoreData(t *testing.T) {
 			input: `494.94 GB (99.04%)`,
 			want:  []float64{531437778370.559998, 0.9904},
 		},
+		{
+			// Just to check https://github.com/peimanja/artifactory_exporter/issues/139
+			input: `1.0 GB (1.0%)`,
+			want:  []float64{1073741824.000000, 0.0100},
+		},
 	}
 	for _, tc := range tests {
 		gotSize, gotPercent, err := fakeExporter.convArtiToPromFileStoreData(tc.input)