store events #106
Merged
store events #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the tx search in the extrinsic block to a search directly in the starknet block using the transaction hash cache to retrieve the index
Added the OrderedEvents data structure to store an event related to a tx index of the block. Added events in the get_transaction_receipt method. #31
don't wait the tx inclusion in the block and just return TxnHashNotFound
formate comments
antiyro
approved these changes
Jan 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
The current implementation has some bugs related to transaction search and does not save transaction events
What is the new behavior?
Does this introduce a breaking change?
No
Other information