Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 use block storage events #111

Merged
merged 6 commits into from
Feb 10, 2024
Merged

fix: 🐛 use block storage events #111

merged 6 commits into from
Feb 10, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Feb 5, 2024 •
edited
Loading

remove runtime_api() in get_events and use the events storage

Pull Request type

  • Bugfix

What is the current behavior?

  • RPC method get_events does not work because the storage substrate does not store the events
  • pagination does not work beyond 2 pages

What is the new behavior?

  • 'get_events' uses the Starknet block with ordered_events
  • the format and parsing of to 'Struct ContinuationToken' is now in decimal
  • paging behavior now works directly on the filter events of a block

Does this introduce a breaking change?

Other information

@jbcaron jbcaron marked this pull request as ready for review February 9, 2024 20:04
@jbcaron jbcaron self-assigned this Feb 10, 2024
@antiyro antiyro merged commit a9ba8cd into KasarLabs:main Feb 10, 2024
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jbcaron jbcaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbcaron @antiyro